You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/24 15:36:35 UTC
[GitHub] [druid] Vespira opened a new pull request #11988: Update tutorial-compaction.md to change an unclear statement
Vespira opened a new pull request #11988:
URL: https://github.com/apache/druid/pull/11988
Unclear statement on the explanation of tuningConfig section.
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
Tiny PR just to modify an unclear statement in the tutorial documentation section about Segment compaction task.
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
Rephrased a little bit sentence
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a change in pull request #11988: Update tutorial-compaction.md to change an unclear statement
Posted by GitBox <gi...@apache.org>.
kfaraz commented on a change in pull request #11988:
URL: https://github.com/apache/druid/pull/11988#discussion_r761913713
##########
File path: docs/tutorials/tutorial-compaction.md
##########
@@ -90,7 +90,7 @@ We have included a compaction task spec for this tutorial datasource at `quickst
This will compact all segments for the interval `2015-09-12/2015-09-13` in the `compaction-tutorial` datasource.
-The parameters in the `tuningConfig` control how many segments will be present in the compacted set of segments.
+The parameters in the `tuningConfig` gives control of how many maximum rows will be present in each segments, among other tuning configurations.
Review comment:
Maybe retain some of the original language too (about the no. of segments) as it connects with the next paragraph.
```suggestion
The parameters in the `tuningConfig` control the maximum number rows present in each compacted segment and thus affect the number of segments created by compaction.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #11988: Update tutorial-compaction.md to change an unclear statement
Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11988:
URL: https://github.com/apache/druid/pull/11988#issuecomment-978773694
Thanks for the changes @Vespira .
But I think the old statement is probably easier to understand, especially if you read it with the statement right after.
> In this tutorial example, only one compacted segment will be created per hour, as each hour has less rows than the 5000000 `maxRowsPerSegment` (note that the total number of rows is 39244).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] techdocsmith commented on a change in pull request #11988: Update tutorial-compaction.md to change an unclear statement
Posted by GitBox <gi...@apache.org>.
techdocsmith commented on a change in pull request #11988:
URL: https://github.com/apache/druid/pull/11988#discussion_r760503654
##########
File path: docs/tutorials/tutorial-compaction.md
##########
@@ -90,7 +90,7 @@ We have included a compaction task spec for this tutorial datasource at `quickst
This will compact all segments for the interval `2015-09-12/2015-09-13` in the `compaction-tutorial` datasource.
-The parameters in the `tuningConfig` control how many segments will be present in the compacted set of segments.
+The parameters in the `tuningConfig` gives control of how many maximum rows will be present in each segments, among other tuning configurations.
Review comment:
```suggestion
The parameters in the `tuningConfig` control the maximum number of rows present in each of the compacted segments and other tuning configurations.
```
@kfaraz , @Vespira what about this clarification?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a change in pull request #11988: Update tutorial-compaction.md to change an unclear statement
Posted by GitBox <gi...@apache.org>.
kfaraz commented on a change in pull request #11988:
URL: https://github.com/apache/druid/pull/11988#discussion_r761913713
##########
File path: docs/tutorials/tutorial-compaction.md
##########
@@ -90,7 +90,7 @@ We have included a compaction task spec for this tutorial datasource at `quickst
This will compact all segments for the interval `2015-09-12/2015-09-13` in the `compaction-tutorial` datasource.
-The parameters in the `tuningConfig` control how many segments will be present in the compacted set of segments.
+The parameters in the `tuningConfig` gives control of how many maximum rows will be present in each segments, among other tuning configurations.
Review comment:
Thanks for simplifying the language, @techdocsmith!
Maybe retain some of the original language too (about the no. of segments) as it connects with the next paragraph.
```suggestion
The parameters in the `tuningConfig` control the maximum number of rows present in each compacted segment and thus affect the number of segments in the compacted set.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a change in pull request #11988: Update tutorial-compaction.md to change an unclear statement
Posted by GitBox <gi...@apache.org>.
kfaraz commented on a change in pull request #11988:
URL: https://github.com/apache/druid/pull/11988#discussion_r761913713
##########
File path: docs/tutorials/tutorial-compaction.md
##########
@@ -90,7 +90,7 @@ We have included a compaction task spec for this tutorial datasource at `quickst
This will compact all segments for the interval `2015-09-12/2015-09-13` in the `compaction-tutorial` datasource.
-The parameters in the `tuningConfig` control how many segments will be present in the compacted set of segments.
+The parameters in the `tuningConfig` gives control of how many maximum rows will be present in each segments, among other tuning configurations.
Review comment:
Thanks for simplifying the language, @techdocsmith!
Maybe retain some of the original language too (about the no. of segments) as it connects with the next paragraph.
```suggestion
The parameters in the `tuningConfig` control the maximum number of rows present in each compacted segment and thus affect the number of segments created by compaction.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org