You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/10/22 05:11:07 UTC
[GitHub] [iotdb] qiaojialin commented on a diff in pull request #7673: [To rel/0.13][IOTDB-4675] Use createMultiTimeseries to optimize MLogLoader
qiaojialin commented on code in PR #7673:
URL: https://github.com/apache/iotdb/pull/7673#discussion_r1002351926
##########
server/src/main/java/org/apache/iotdb/db/tools/mlog/MLogLoader.java:
##########
@@ -252,19 +272,12 @@ public static void parseFileAndLoad() throws Exception {
fillTagsAndOffset(createTimeSeriesPlan);
}
}
- session.createTimeseries(
- createTimeSeriesPlan.getPath().getFullPath(),
- createTimeSeriesPlan.getDataType(),
- createTimeSeriesPlan.getEncoding(),
- createTimeSeriesPlan.getCompressor(),
- createTimeSeriesPlan.getProps(),
- createTimeSeriesPlan.getTags(),
- createTimeSeriesPlan.getAttributes(),
- createTimeSeriesPlan.getAlias());
+ addBatchAndCheck(createTimeSeriesPlan);
break;
case CREATE_ALIGNED_TIMESERIES:
CreateAlignedTimeSeriesPlan createAlignedTimeSeriesPlan =
(CreateAlignedTimeSeriesPlan) plan;
+ logger.info("create aligned");
Review Comment:
debug
##########
server/src/main/java/org/apache/iotdb/db/tools/mlog/MLogLoader.java:
##########
@@ -381,12 +399,13 @@ public static void parseFileAndLoad() throws Exception {
deactivateTemplatePlan.getPrefixPath().getFullPath());
break;
default:
- logger.warn("Skip load plan {}", plan);
+ // logger.warn("Skip load plan {}", plan);
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org