You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2023/03/01 11:25:00 UTC
[jira] [Commented] (CASSANDRA-18106) Update CCM for JDK17 and revise current JDK detection strategy
[ https://issues.apache.org/jira/browse/CASSANDRA-18106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695012#comment-17695012 ]
Michael Semb Wever commented on CASSANDRA-18106:
------------------------------------------------
bq. Interesting, they [failed|https://app.circleci.com/pipelines/github/driftx/cassandra/863/workflows/b154a40b-891a-42d4-9b4e-8e83db4881b3/jobs/12465/tests] again.
I see in it's [logs|https://circleci.com/api/v1.1/project/github/driftx/cassandra/12556/output/106/0?file=true&allocation-id=63fe8dc3d05a281ea75445cf-0-build%2F781E9B7A] that ccm is trying to start up with jdk8, not 11.
I pushed your branch and repeated this failure [here|https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/108/workflows/a84d9a40-2090-4844-a7ad-96490f17ebb5/jobs/4027].
When I removed all {{JAVA8_HOME}} and {{JAVA11_HOME}} env properties from the circleci configs, it correctly runs ccm with jdk11 and fixed the tests, see [here|https://app.circleci.com/pipelines/github/michaelsembwever/cassandra/109/workflows/f4206b43-b6b1-415b-944f-2015ab70ab1c/jobs/4029].
> Update CCM for JDK17 and revise current JDK detection strategy
> --------------------------------------------------------------
>
> Key: CASSANDRA-18106
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18106
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Brandon Williams
> Priority: Normal
> Fix For: 4.x
>
>
> As part of CASSANDRA-16895 initial POC an initial version of CCM patch was created. This needs to be revisited and reviewed
> Recently we closed CASSANDRA-18039 which brought questions, probably we need to revise how we detect JDK versions in CCM and whether it is correct. To the best of my knowledge there are certain tests in the repo around that and they pass so my guess is we need to revise just the strategy and maybe document it explicitly or consider if we want any changes to be applied. Also, we need to be careful with breaking changes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org