You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/08/19 22:50:09 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request #5320: NIFI-9067 Upgraded JAXB Runtime from 2.3.0 to 2.3.5
exceptionfactory opened a new pull request #5320:
URL: https://github.com/apache/nifi/pull/5320
#### Description of PR
NIFI-9067 Upgrades JAXB Runtime dependencies from 2.3.0 to 2.3.5 and also upgrades the JAXB API dependency from 2.3.0 to 2.3.3. This update resolves the following warning when running NiFi, NiFi Stateless, NiFi Toolkit, or MiNiFi on Java 11:
```
Illegal reflective access by com.sun.xml.bind.v2.runtime.reflect.opt.Injector
```
Upgrading versions also involves migrating to the currently maintained Maven packages. The JAXB API Maven coordinates are now `jakarta.xml.bind:jakarta.xml.bind-api` instead of `javax.xml.bind:jaxb-api`. The JAXB implementation is now packaged as `org.glassfish.jaxb:jaxb-runtime`. The JAXB API package has a transitive dependency on `jakarta.activation-api`, so explicit declaration in multiple locations is no longer necessary. Updates include indicating the new Maven coordinates and associated licenses in the NiFi assembly notices.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [X] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #5320: NIFI-9067 Upgraded JAXB Runtime from 2.3.0 to 2.3.5
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5320:
URL: https://github.com/apache/nifi/pull/5320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] theBestAndrew commented on a change in pull request #5320: NIFI-9067 Upgraded JAXB Runtime from 2.3.0 to 2.3.5
Posted by GitBox <gi...@apache.org>.
theBestAndrew commented on a change in pull request #5320:
URL: https://github.com/apache/nifi/pull/5320#discussion_r696550512
##########
File path: nifi-assembly/pom.xml
##########
@@ -769,30 +769,20 @@ language governing permissions and limitations under the License. -->
<!-- dependencies for jaxb/activation/annotation for running NiFi on Java 11 -->
<!-- TODO: remove these once minimum Java version is 11 -->
Review comment:
The comment says to remove the jaxb dependencies for Java 11. If the comment is wrong, it should be removed. There are similar comment locations given in NIFI-9047.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] theBestAndrew commented on a change in pull request #5320: NIFI-9067 Upgraded JAXB Runtime from 2.3.0 to 2.3.5
Posted by GitBox <gi...@apache.org>.
theBestAndrew commented on a change in pull request #5320:
URL: https://github.com/apache/nifi/pull/5320#discussion_r696553862
##########
File path: nifi-assembly/pom.xml
##########
@@ -769,30 +769,20 @@ language governing permissions and limitations under the License. -->
<!-- dependencies for jaxb/activation/annotation for running NiFi on Java 11 -->
<!-- TODO: remove these once minimum Java version is 11 -->
Review comment:
I realize now that this ticket is for improving running on Java 11, not a change for NiFi 2.0 when Java 11 is the minimum supported version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org