[GitHub] [helix] pkuwm commented on a change in pull request #528: Suggested fixes by iCR, OpenRefactory, Inc.

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #528: Suggested fixes by iCR, OpenRefactory, Inc.
URL: https://github.com/apache/helix/pull/528#discussion_r344298544
 
 

 ##########
 File path: recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskExecutionDemo.java
 ##########
 @@ -121,7 +121,7 @@ private static void populateDummyData(TaskResultStore taskResultStore) throws Ex
     float fraudProbability = 0.01f;
     float clickProbability = 0.01f;
     int numImps = NUM_IMP_EVENTS;
-    Random rand = new Random();
+    SecureRandom rand = new SecureRandom();
 
 Review comment:
   I wonder if SecureRandom is a must here. Are the random numbers here for security or cryptographic purpose? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org