You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/28 18:45:29 UTC

[GitHub] [spark] amaliujia commented on pull request #38800: [SPARK-41264][CONNECT][PYTHON] Make Literal support more datatypes

amaliujia commented on PR #38800:
URL: https://github.com/apache/spark/pull/38800#issuecomment-1329581277

   LGTM
   
   A big left work is testing coverage over literals. For example does `NaN`, `+inf`, `-inf` can pass through Connect proto and any test case? I also have a tons of questions about value range for timestamp. 
   
   This is not because current PR so that is not a blocker for this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org