You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/19 05:27:18 UTC
[GitHub] [apisix] membphis commented on a diff in pull request #8116: refactor: adjusting the position of ai modules
membphis commented on code in PR #8116:
URL: https://github.com/apache/apisix/pull/8116#discussion_r998954794
##########
apisix/http/route.lua:
##########
@@ -21,7 +21,7 @@ local service_fetch = require("apisix.http.service").get
local core = require("apisix.core")
local expr = require("resty.expr.v1")
local plugin_checker = require("apisix.plugin").plugin_checker
-local ai = require("apisix.core.ai")
+local internal_event = require("apisix.internal_event")
Review Comment:
I think `event` is a good name, we can remove `internal_`
##########
apisix/http/route.lua:
##########
@@ -92,7 +92,7 @@ function _M.create_radixtree_uri_router(routes, uri_routes, with_parameter)
end
end
- ai.routes_analyze(uri_routes)
+ internal_event.push_event("routes_change", uri_routes)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org