[GitHub] [dubbo] EarthChen commented on a diff in pull request #10726: Enqueue soon

[GitBox <gi...@apache.org>]

EarthChen commented on code in PR #10726:
URL: https://github.com/apache/dubbo/pull/10726#discussion_r991257352


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/ClientStream.java:
##########
@@ -69,9 +69,7 @@ default void onComplete(TriRpcStatus status, Map<String, Object> attachments,
 
     /**
      * No more data will be sent, half close this stream to wait server response.
-     *
-     * @return a future of send result
      */
-    Future<?> halfClose();
+    void halfClose();

Review Comment:
   why change?



##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/frame/MessageFramer.java:
##########
@@ -0,0 +1,55 @@
+package org.apache.dubbo.rpc.protocol.tri.frame;
+
+import org.apache.dubbo.rpc.protocol.tri.command.DataQueueCommand;
+import org.apache.dubbo.rpc.protocol.tri.command.EndStreamQueueCommand;
+import org.apache.dubbo.rpc.protocol.tri.transport.WriteQueue;
+
+import java.util.Queue;
+import java.util.concurrent.ConcurrentLinkedQueue;
+
+/**

Review Comment:
   remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org