[GitHub] [flink] zentol commented on a change in pull request #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #9517: [FLINK-13779][metrics] PrometheusPushGatewayReporter support push metrics with groupingKey
URL: https://github.com/apache/flink/pull/9517#discussion_r319761105
 
 

 ##########
 File path: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterOptions.java
 ##########
 @@ -63,4 +63,14 @@
 				" Before disabling this option please ensure that your" +
 				" label values meet the %s.", LinkElement.link("https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels", "Prometheus requirements"))
 			.build());
+
+	public static final ConfigOption<String> GROUPING_KEY = ConfigOptions
+		.key("groupingKey")
+		.defaultValue("")
+			.withDescription(Description.builder()
+				.text("Specifies the grouping key which is the group and global labels of all metrics." +
+					" The label name and value is separated with '=', and labels are separated with ';', e.g. k1=v1;k2=v2." +
 
 Review comment:
   ```suggestion
   					" The label name and value are separated by '=', labels are separated by ';', e.g., k1=v1;k2=v2." +
   ```
   
   Bonus points for replacing the example with a `code` element.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services