[GitHub] [airflow] potiuk commented on pull request #9973: Improve compatibility with mssql

[GitBox <gi...@apache.org>]

potiuk commented on pull request #9973:
URL: https://github.com/apache/airflow/pull/9973#issuecomment-818973917


   I look through that one again, it looks it's close. I think it's about the time to add tests to the CI. I suggest to run all the tests locally first (but you likely has done it already). If you have a bit more powerful machine, the fastest way to run all the tests is to run `BACKEND="mssql" ./scripts/ci/testing/ci_run_airflow_testing.sh` - this should run a complete set of tests and report all problems.
   
   Then adding it to the CI are those things::
   
   1) duplicate the `tests-mysql:` entry in ci.yml (https://github.com/apache/airflow/blob/master/.github/workflows/ci.yml#L713)
   
   2) replace all the mysql with mssql (the `test-mysql` is also mentioned a bit in ci,yml file and there also you should add it. https://github.com/apache/airflow/blob/master/.github/workflows/ci.yml#L904
   
   3) Then you need to add a few variables to build-info (copy & replace mysql with mssql) 
   https://github.com/apache/airflow/blob/6e31465a30dfd17e2e1409a81600b2e83c910036/.github/workflows/ci.yml#L143
   and
   https://github.com/apache/airflow/blob/6e31465a30dfd17e2e1409a81600b2e83c910036/.github/workflows/ci.yml#L151
   
   4) In selective checks copy the mysl -related stuff here::
   https://github.com/apache/airflow/blob/6e31465a30dfd17e2e1409a81600b2e83c910036/scripts/ci/selective_ci_checks.sh#L99
   https://github.com/apache/airflow/blob/6e31465a30dfd17e2e1409a81600b2e83c910036/scripts/ci/selective_ci_checks.sh#L107
   https://github.com/apache/airflow/blob/6e31465a30dfd17e2e1409a81600b2e83c910036/scripts/ci/selective_ci_checks.sh#L117
   
   (follow `mysql` again). You can exclude any version of python (3.6 for example). This exclusion is to limit matrix of db x python we run in CI. 
   
   5) And finally add CURRENT_MSSQL_VERSIONS and use it few lines below (same as mysql) - this is used by selective checks
   https://github.com/apache/airflow/pull/9973/files#diff-076ea62635e708e580c5e8e034404c7f8fbb55115ab3a10c60da502d7b1285fcL102
   
   We've never done that, and it happens rarely, so it is scattered around the code a bit.
   
   This will enable running all the `mssql` tests on CI. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org