You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/10/14 15:44:12 UTC
[PR] RATIS-2747. make_rc.sh help fails due to unbound variable WORKINGDIR [ratis-thirdparty]
adoroszlai opened a new pull request, #210:
URL: https://github.com/apache/ratis-thirdparty/pull/210
## What changes were proposed in this pull request?
`make_rc.sh` should print help without arguments, but it fails due to unbound variable.
```
export RATISVERSION=1.1.1
export RC=rc1
export CODESIGNINGKEY="value"
./dev-support/make_rc.sh
...
./dev-support/make_rc.sh: line 211: WORKINGDIR: unbound variable
```
https://issues.apache.org/jira/browse/RATIS-2747
## How was this patch tested?
Same repro steps.
```
Please choose from available phases (eg. make_rc.sh 1-prepare-src):
1-prepare-src: This is the first step. It modifies the mvn version, creates the git tag and
builds the project to create the source artifacts.
IT INCLUDES A GIT RESET + CLEAN. ALL LOCAL CHANGES WILL BE LOST!
2-verify-bin: The source artifact is copied to ../ratis-thirdparty.1.1.1-rc1 and the project built from source.
This is an additional check as the the released source artifact should be enough to build the whole project.
....
```
https://github.com/adoroszlai/ratis-thirdparty/actions/runs/38591124742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2747. make_rc.sh help fails due to unbound variable WORKINGDIR [ratis-thirdparty]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #210:
URL: https://github.com/apache/ratis-thirdparty/pull/210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2747. make_rc.sh help fails due to unbound variable WORKINGDIR [ratis-thirdparty]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #210:
URL: https://github.com/apache/ratis-thirdparty/pull/210#issuecomment-6179421206
Thanks @amaliujia for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org