[jira] [Resolved] (IMPALA-4070) ClientCache::DoRpc() doesn't always return the right error for timeouts

["Tim Armstrong (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-4070.
-----------------------------------
    Resolution: Later

> ClientCache::DoRpc() doesn't always return the right error for timeouts
> -----------------------------------------------------------------------
>
>                 Key: IMPALA-4070
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4070
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Distributed Exec
>    Affects Versions: Impala 2.7.0
>            Reporter: Henry Robinson
>            Assignee: Henry Robinson
>            Priority: Minor
>
> In {{DoRpc()}}:
> {code}
>  if (IsRecvTimeoutTException(e)) {
>         return Status(TErrorCode::RPC_RECV_TIMEOUT, strings::Substitute(
>             "Client $0 timed-out during recv call.", TNetworkAddressToString(address_)));
>       }
>       // <snip>
>       const Status& status = Reopen();
>       if (!status.ok()) {
>         if (retry_is_safe != NULL) *retry_is_safe = true;
>         return Status(TErrorCode::RPC_CLIENT_CONNECT_FAILURE, status.GetDetail());
>       }
>       try {
>         (client_->*f)(*response, request);
>       } catch (apache::thrift::TException& e) {
>         // By this point the RPC really has failed.
>         // TODO: Revisit this logic later. It's possible that the new connection
>         // works but we hit timeout here.
>         // *********** COULD BE A TIMEOUT EXCEPTION *************
>         // *********** NEEDS IsRecvTimeoutTException()    *************
>         return Status(TErrorCode::RPC_GENERAL_ERROR, e.what());
>       }
> {code}
> This mostly affects test code that tries to trigger a timeout and confirms that one happened.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)