You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/30 22:40:17 UTC
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4582
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. This patch fixes:
1. Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions.
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
---
M LICENSE.txt
M README.md
M be/src/codegen/CMakeLists.txt
M fe/src/test/resources/hbase-site.xml.template
D llvm-ir/test-loop.bc
M testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
M testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
7 files changed, 169 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/4582/1
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#3).
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. He asked:
1. "Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions."
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
---
M LICENSE.txt
M README.md
M be/src/codegen/CMakeLists.txt
M bin/rat_exclude_files.txt
M fe/src/test/resources/hbase-site.xml.template
D llvm-ir/test-loop.bc
M testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
M testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
8 files changed, 169 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/4582/3
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 5:
Tim, Taras, any other concerns?
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Taras Bobrovytsky (Code Review)" <ge...@cloudera.org>.
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4582/1//COMMIT_MSG
Commit Message:
PS1, Line 12: Please
It's kind of strange that this point starts with the word "Please"
http://gerrit.cloudera.org:8080/#/c/4582/1/LICENSE.txt
File LICENSE.txt:
PS1, Line 269:
Remove these trailing white spaces.
http://gerrit.cloudera.org:8080/#/c/4582/1/README.md
File README.md:
PS1, Line 30: right now.
at the moment
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/4582/1//COMMIT_MSG
Commit Message:
PS1, Line 12: Please
> It's kind of strange that this point starts with the word "Please"
It was a quote; I've now quoted it.
http://gerrit.cloudera.org:8080/#/c/4582/1/LICENSE.txt
File LICENSE.txt:
PS1, Line 269:
> Remove these trailing white spaces.
Done
http://gerrit.cloudera.org:8080/#/c/4582/1/README.md
File README.md:
PS1, Line 30: right now.
> at the moment
Done
http://gerrit.cloudera.org:8080/#/c/4582/2/llvm-ir/test-loop.bc
File llvm-ir/test-loop.bc:
> Did you run tests? This file is required by llvm-codegen-test.
I did run tests. This patch causes this file to be listed as an explicit requirement for llvm-codegen-test; see the CMake file.
The voter on the general@ mailing list said that binaries are OK, but not if they are compiled source code.
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 6: Code-Review+2
rebase, carry Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#5).
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. He asked:
1. "Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions."
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
---
M LICENSE.txt
M README.md
M be/src/codegen/CMakeLists.txt
M bin/rat_exclude_files.txt
M fe/src/test/resources/hbase-site.xml.template
D llvm-ir/test-loop.bc
M testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
M testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
8 files changed, 144 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/4582/5
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. He asked:
1. "Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions."
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Reviewed-on: http://gerrit.cloudera.org:8080/4582
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M LICENSE.txt
M README.md
M be/src/codegen/CMakeLists.txt
M bin/rat_exclude_files.txt
M fe/src/test/resources/hbase-site.xml.template
D llvm-ir/test-loop.bc
M testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
M testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
8 files changed, 144 insertions(+), 10 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4582/2/llvm-ir/test-loop.bc
File llvm-ir/test-loop.bc:
Did you run tests? This file is required by llvm-codegen-test.
IMO it doesn't make sense to remove binary test data. Other apache projects check in this kind of thing, e.g. https://github.com/apache/avro/tree/master/share/test/data
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has uploaded a new patch set (#2).
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
IMPALA-4230: ASF policy issues from 2.7.0 rc3.
In our IPMC vote to release 2.7.0 rc3, Justing Mclean pointed out a
number of issues of compliance with ASF policy. This patch fixes:
1. Please place build instruction and supported platforms in the
README. The wiki may change over time and that may make it difficult
to build older versions.
2. Remove binary file llvm-ir/test-loop.bc
3. Add be/src/gutil/valgrind.h,
shell/ext-py/sqlparse-0.1.14/sqlparse/pipeline.py and
cmake_modules/FindJNI.cmake, normalize.css (embedded in bootstrap.css)
to LICENSE.txt
4. Fix be/src/thirdparty/squeasel/squeasel* in LICENSE.txt
5. Remove outdated copyright lines from HBase (see
https://issues.apache.org/jira/browse/HBASE-3870)
6. Remove duplicate jquery notice from LICENSE.txt
Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
---
M LICENSE.txt
M README.md
M be/src/codegen/CMakeLists.txt
M bin/rat_exclude_files.txt
M fe/src/test/resources/hbase-site.xml.template
D llvm-ir/test-loop.bc
M testdata/cluster/node_templates/common/etc/hadoop/conf/hadoop-policy.xml
M testdata/cluster/node_templates/common/etc/hadoop/conf/log4j.properties.tmpl
8 files changed, 169 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/4582/2
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4230: ASF policy issues from 2.7.0 rc3.
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4230: ASF policy issues from 2.7.0 rc3.
......................................................................
Patch Set 6: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/316/
--
To view, visit http://gerrit.cloudera.org:8080/4582
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30ff77d7ac28ce67511c200764fba19ae69922e0
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tb...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No