You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/28 09:48:06 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #399: nuttx:
rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
anchao opened a new pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399
Rename "Makefile" to "Nuttx.mk" to ensure the uniqueness
of "Makefile" in different projects, which is meaningful
to avoid frequent overwriting of "Makefile" if we want
to use the same project to compile in different platforms.
which also makes "Nuttx.mk" easier to join other open source
projects (like Android.mk) to avoid unnecessary porting work.
Rename:
Makefile -> Nuttx.mk
Make.defs -> Nuttx.defs
Make.dep -> Nuttx.dep
Signed-off-by: chao.an <an...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo closed pull request #399: nuttx: rename
Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename
Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592536135
Thie impacts of a change like this are too great. This cannot be accepted. A change like this should at least have a vote from all PPMC member. It is inappropriate for you to do this unilaterally without agreement from everyone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #399:
nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592522078
> This change is apaplling. I don't thing it should be merged. Let's keep the name Makefile. Nuttx.mk is a horrible idea.
The reason behind this change is that we found many open source projects use Makefile to enter into their build system. If we don't change the Makefile name in apps, it is impossible to incoprate the nuttx build script into the mainline repo. Do you have other idea to upstream NuttX specific Makefile? Many project accept the contributor upstream Android.mk to their repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename
Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592519979
This change is apaplling. I don't thing it should be merged. Let's keep the name Makefile. Nuttx.mk is a horrible idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #399: nuttx: rename
Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592523040
I still don't like it. I have no concern for other open source projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #399: nuttx:
rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #399: nuttx: rename Makefile/Make.defs/Make.dep to Nuttx.mk/Nuttx.defs/Nuttx.dep
URL: https://github.com/apache/incubator-nuttx/pull/399#issuecomment-592522078
> This change is apaplling. I don't thing it should be merged. Let's keep the name Makefile. Nuttx.mk is a horrible idea.
The reason behind this change is that we found many open source projects use Makefile to enter into their build system. If we don't change the Makefile name in apps, it is impossible to incoprate the nuttx build script into the mainline repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services