You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/22 03:47:31 UTC

[GitHub] [flink] fsk119 opened a new pull request #13446: [FLINK-18779]Support the SupportsFilterPushDown for LookupTableSource

fsk119 opened a new pull request #13446:
URL: https://github.com/apache/flink/pull/13446


   1. add rule that will transpose the filter and snapshot and PushFilterIntoTableSourceScanRule will push filter into DynamicTableSource.
   2. add tests including ut, itcase.
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *Add rule that will push filter into lookup table source.*
   
   
   ## Brief change log
   
   *(for example:)*
     - *add rule that will transpose between filter and snapshot.*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Added single rule test.*
     - *Added test with all rules.*
     - *Added e2e tests.*
   
     ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753",
       "triggerID" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 274f2a01b0c9549bb79a62bfd2bf06dcc1a13538 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742) 
   * 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zstraw commented on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
zstraw commented on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-906854613


   hi @fsk119 , why did you close this pr? any problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696484481


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 (Fri Feb 19 07:22:30 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753",
       "triggerID" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10d22d3c1c5b291c3bd6d730b00f152a675d7bd4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729) 
   * 3294f531720487c5fea84527c21d512a63ad4213 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zstraw commented on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
zstraw commented on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-907935880


   Thank you. I take a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753",
       "triggerID" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   * 274f2a01b0c9549bb79a62bfd2bf06dcc1a13538 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742) 
   * 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6753) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   * 274f2a01b0c9549bb79a62bfd2bf06dcc1a13538 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13446: [FLINK-18779]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696484481






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     }, {
       "hash" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   * 274f2a01b0c9549bb79a62bfd2bf06dcc1a13538 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6742) 
   * 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13446: [FLINK-18779]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696484481






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     }, {
       "hash" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "274f2a01b0c9549bb79a62bfd2bf06dcc1a13538",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   * 274f2a01b0c9549bb79a62bfd2bf06dcc1a13538 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 commented on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
fsk119 commented on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-906872956


   Because this PR has too many conflicts with the master branch and I don't have time to resolve this recently. If you are interested in these feature, you can just resolve these conflicts and open a new PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696488728


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729",
       "triggerID" : "10d22d3c1c5b291c3bd6d730b00f152a675d7bd4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "3294f531720487c5fea84527c21d512a63ad4213",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736",
       "triggerID" : "3294f531720487c5fea84527c21d512a63ad4213",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 10d22d3c1c5b291c3bd6d730b00f152a675d7bd4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6729) 
   * 3294f531720487c5fea84527c21d512a63ad4213 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6736) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fsk119 closed pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
fsk119 closed pull request #13446:
URL: https://github.com/apache/flink/pull/13446


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13446: [FLINK-18779][table sql/planner]Support the SupportsFilterPushDown for LookupTableSource

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13446:
URL: https://github.com/apache/flink/pull/13446#issuecomment-696484481


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 41d632a55eeed78fdeb78a23ba5cc68ca12fc1f1 (Tue Dec 14 09:06:41 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org