You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/29 14:37:01 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #22919: Add set state in Go

damccorm commented on code in PR #22919:
URL: https://github.com/apache/beam/pull/22919#discussion_r957425179


##########
sdks/go/pkg/beam/core/runtime/exec/translate.go:
##########
@@ -495,10 +495,22 @@ func (b *builder) makeLink(from string, id linkID) (Node, error) {
 							} else if ms := spec.GetMapSpec(); ms != nil {
 								cID = ms.ValueCoderId
 								kcID = ms.KeyCoderId
+							} else if ss := spec.GetSetSpec(); ss != nil {
+								kcID = ss.ElementCoderId
+							} else {
+								a := spec.GetSpec().(*pipepb.StateSpec_SetSpec)

Review Comment:
   Oops, good catch - that was leftover from me debugging a different issue and I didn't cut the whole block correctly. Fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org