You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "TakaHiR07 (via GitHub)" <gi...@apache.org> on 2023/07/18 09:32:13 UTC

[GitHub] [pulsar] TakaHiR07 opened a new pull request, #20832: [improve][broker] Heartbeat topic enable checkMessageExpire

TakaHiR07 opened a new pull request, #20832:
URL: https://github.com/apache/pulsar/pull/20832

   ### Motivation
   
   Running pulsar cluster for a long time, we found there are thousands of ledgers of heartbeat topic. The reason is heartbeat topic do not clean the expired message because it is systemTopic. The behaviour change since this pr https://github.com/apache/pulsar/pull/13611.
   
   I think it is no need to keep heartbeat topic message permanently and we'd better clean the expired message and the ledger.
   
   ### Modifications
   
   modify checkMessageExpire()
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: <!-- ENTER URL HERE -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] TakaHiR07 commented on pull request #20832: [improve][broker] Heartbeat topic enable checkMessageExpire

Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #20832:
URL: https://github.com/apache/pulsar/pull/20832#issuecomment-1651354107

   > The fix is good, Could you add a test?
   
   Test is done. @Technoboy- 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [improve][broker] Heartbeat topic enable checkMessageExpire [pulsar]

Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on PR #20832:
URL: https://github.com/apache/pulsar/pull/20832#issuecomment-1761181019

   Actually in our pulsar environment, compaction is trigger, thats the reason why ledger not clean.
   
   With this pr, https://github.com/apache/pulsar/pull/14643. Heartbeat topic no longer trigger compaction. This problem can be fix. 
   
   So close this pr. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [improve][broker] Heartbeat topic enable checkMessageExpire [pulsar]

Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 closed pull request #20832: [improve][broker] Heartbeat topic enable checkMessageExpire
URL: https://github.com/apache/pulsar/pull/20832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #20832: [improve][broker] Heartbeat topic enable checkMessageExpire

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20832:
URL: https://github.com/apache/pulsar/pull/20832#issuecomment-1667433057

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #20832: [improve][broker] Heartbeat topic enable checkMessageExpire

Posted by "Technoboy- (via GitHub)" <gi...@apache.org>.
Technoboy- commented on PR #20832:
URL: https://github.com/apache/pulsar/pull/20832#issuecomment-1641527404

   The fix is good, Could you add a test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #20832: [improve][broker] Heartbeat topic enable checkMessageExpire

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20832:
URL: https://github.com/apache/pulsar/pull/20832#issuecomment-1709344349

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org