[jira] [Closed] (FLINK-7821) Replace Table.limit() by Table.fetch() and Table.offset()

["Fabian Hueske (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-7821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabian Hueske closed FLINK-7821.
--------------------------------
       Resolution: Implemented
    Fix Version/s: 1.4.0

Implemented for 1.4.0 with e1c7e490395c44913e816966b2fa3b8bfeb18160

> Replace Table.limit() by Table.fetch() and Table.offset()
> ---------------------------------------------------------
>
>                 Key: FLINK-7821
>                 URL: https://issues.apache.org/jira/browse/FLINK-7821
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>             Fix For: 1.4.0
>
>
> The Table API method limit() exists in two variants:
> - {{limit(offset)}} returns all but the first {{offset}} records.
> - {{limit(offset, fetch)}} returns {{fetch}} records starting from the {{offset}}'s record.
> Especially, the behavior of {{limit(offset)}} is confusing because one would rather expect a behavior of returning the {{offset}} first records instead of all but the {{offset}} first records.
> Moreover, the only way to return the first {{x}} records is to specify a {{0}} offset as {{limit(0, x)}}.
> I propose to deprecate and replace both {{limit()}} variants by two new methods {{Table.offset(offset)}} and {{Table.fetch(fetch)}} that can be combined as follows:
> {code}
> table.orderBy(...).fetch(x)
> table.orderBy(...).offset(x)
> table.orderBy(...).offset(x).fetch(y)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)