You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/02/18 23:38:33 UTC

Review Request 18245: Use user.signingkey for tag-signing.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18245/
-----------------------------------------------------------

Review request for Aurora, Jake Farrell and Bill Farner.


Repository: aurora


Description
-------

Use user.signingkey for tag-signing.

Rather than use UID require an explicitly-set key ID, following recommendations at [1].

[1] http://www.apache.org/dev/openpgp.html


Diffs
-----

  build-support/release/tag-release 61760aa162bb09aa0725001f878ad2bef3dcfdbd 

Diff: https://reviews.apache.org/r/18245/diff/


Testing
-------

Tested with user.signingkey set and unset on local merged master.


Thanks,

Kevin Sweeney

Re: Review Request 18245: Use user.signingkey for tag-signing.

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18245/#review34812
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Feb. 18, 2014, 10:38 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18245/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2014, 10:38 p.m.)
> 
> 
> Review request for Aurora, Jake Farrell and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use user.signingkey for tag-signing.
> 
> Rather than use UID require an explicitly-set key ID, following recommendations at [1].
> 
> [1] http://www.apache.org/dev/openpgp.html
> 
> 
> Diffs
> -----
> 
>   build-support/release/tag-release 61760aa162bb09aa0725001f878ad2bef3dcfdbd 
> 
> Diff: https://reviews.apache.org/r/18245/diff/
> 
> 
> Testing
> -------
> 
> Tested with user.signingkey set and unset on local merged master.
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>