You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/02/16 00:53:00 UTC
[jira] [Commented] (TINKERPOP-2163) JavaTranslator performance
enhancements
[ https://issues.apache.org/jira/browse/TINKERPOP-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769919#comment-16769919 ]
ASF GitHub Bot commented on TINKERPOP-2163:
-------------------------------------------
spmallette commented on pull request #1062: TINKERPOP-2163 Improved performance of JavaTranslator method selection
URL: https://github.com/apache/tinkerpop/pull/1062
https://issues.apache.org/jira/browse/TINKERPOP-2163
Every time I think there's nothing else to squeeze out of this class I find something new. This time I cached results of `Method.getParameters()` as well as varargs checks. The former offered the bigger benefit as calls to that method forced a `clone()` of the parameter array, but the latter also helped.
Prior to the change on `tp33` we were getting:
```text
Benchmark Mode Cnt Score Error Units
JavaTranslatorBenchmark.testTranslationLong thrpt 20 25812.057 ± 504.233 ops/s
JavaTranslatorBenchmark.testTranslationMedium thrpt 20 316019.034 ± 13852.097 ops/s
JavaTranslatorBenchmark.testTranslationShort thrpt 20 1403109.145 ± 41460.176 ops/s
JavaTranslatorBenchmark.testTranslationWithStrategy thrpt 20 49316.015 ± 1701.437 ops/s
```
and now, with this change, we're looking at:
```text
Benchmark Mode Cnt Score Error Units
JavaTranslatorBenchmark.testTranslationLong thrpt 20 30270.986 ± 553.973 ops/s
JavaTranslatorBenchmark.testTranslationMedium thrpt 20 385286.380 ± 6572.709 ops/s
JavaTranslatorBenchmark.testTranslationShort thrpt 20 1724457.005 ± 11173.083 ops/s
JavaTranslatorBenchmark.testTranslationWithStrategy thrpt 20 60989.899 ± 533.268 ops/s
```
That's roughly 20% improvement. Not bad.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> JavaTranslator performance enhancements
> ---------------------------------------
>
> Key: TINKERPOP-2163
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2163
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.3.5
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
>
> {{JavaTranslator}} has undergone many performance enhancements, but perhaps some additional improvements can be made. Here is the current speed on 3.3.5 given {{gremlin-benchmark}}:
> {code}
> Benchmark Mode Cnt Score Error Units
> JavaTranslatorBenchmark.testTranslationLong thrpt 20 25812.057 ± 504.233 ops/s
> JavaTranslatorBenchmark.testTranslationMedium thrpt 20 316019.034 ± 13852.097 ops/s
> JavaTranslatorBenchmark.testTranslationShort thrpt 20 1403109.145 ± 41460.176 ops/s
> JavaTranslatorBenchmark.testTranslationWithStrategy thrpt 20 49316.015 ± 1701.437 ops/s
> {code}
> Attempting to improve from there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)