You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "leekeiabstraction (via GitHub)" <gi...@apache.org> on 2025/04/09 08:05:00 UTC

Re: [PR] [FLINK-37478] Adding service labels to flink config [flink]

leekeiabstraction commented on code in PR #26301:
URL: https://github.com/apache/flink/pull/26301#discussion_r2034737608


##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/services/ServiceType.java:
##########
@@ -53,6 +53,7 @@ public Service buildUpExternalRestService(
                 .withNewMetadata()
                 .withName(serviceName)
                 .withLabels(kubernetesJobManagerParameters.getCommonLabels())
+                .addToLabels(kubernetesJobManagerParameters.getRestServiceLabels())

Review Comment:
   nit: Should line 55 be changed to use `addToLabels` method as well? This is so that the code will be more robust to breakage due to line re-ordering as `withLabels` replaces labels map inside the ServiceBuilder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org