You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/15 14:46:20 UTC
[jira] [Commented] (SLING-5849) Inconsistent event handling between
local package importer and its factory
[ https://issues.apache.org/jira/browse/SLING-5849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379502#comment-15379502 ]
ASF GitHub Bot commented on SLING-5849:
---------------------------------------
GitHub user tmaret opened a pull request:
https://github.com/apache/sling/pull/152
SLING-5849 - Inconsistent event handling between local package importer and its factory
* Generate Package Events in the package importer instead of the factory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tmaret/sling SLING-5849
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit 4151cda6cb741ceaa0975ec0180fedf7ce75434c
Author: tmaret <tm...@adobe.com>
Date: 2016-07-15T14:42:35Z
SLING-5849 - Inconsistent event handling between local package importer and its factory
* Generate Package Events in the package importer instead of the factory
----
> Inconsistent event handling between local package importer and its factory
> --------------------------------------------------------------------------
>
> Key: SLING-5849
> URL: https://issues.apache.org/jira/browse/SLING-5849
> Project: Sling
> Issue Type: Bug
> Components: Distribution, Extensions
> Affects Versions: Content Distribution Core 0.1.18
> Reporter: Timothee Maret
> Assignee: Timothee Maret
>
> {{LocalDistributionPackageImporterFactory}} factory sends events [0] which are not sent by the {{LocalDistributionPackageImporter}}. As the two classes are used (depending on the configuration) this creates an inconsistent handling of events.
> [0] https://github.com/apache/sling/blob/006f9d1601c7b3dec1cd3ab303bc34e26a4870a3/contrib/extensions/distribution/core/src/main/java/org/apache/sling/distribution/packaging/impl/importer/LocalDistributionPackageImporterFactory.java#L94
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)