You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/12/12 19:07:54 UTC

[GitHub] [drill] paul-rogers commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

paul-rogers commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues
URL: https://github.com/apache/drill/pull/1923#issuecomment-565141768
 
 
   Revised the PR with some ideas from DRILL-7479. The `ColumnStatistics` class was made generic: it has no type.
   
   `ColumnStatistics` is a metadata description of a column: it, itself, is not a column and does not hold data for the column. It is important that the description describe the column type (which it does via the `type` field). But, the Java type of the metadata description need not reflect the type of the eventual values. (Think of `ColumnMetadata` or `Class` as examples.)
   
   The result was that I could revert a number of changes and the resulting code is a bit cleaner.
   
   This change should not affect any existing, serialized data for this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services