You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/25 07:59:14 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #13330: fix: date picker support date unit with singular and plural
zhaoyongjie opened a new pull request #13330:
URL: https://github.com/apache/superset/pull/13330
### SUMMARY
fix date picker does not support singular data unit
closed: #13264
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Added UT for this case
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #13264
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13330:
URL: https://github.com/apache/superset/pull/13330#discussion_r582624277
##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Last 5 month")
+ expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+ self.assertEqual(result, expected)
+
Review comment:
thanks for reminding me. Because there is `Last 5 months` UT case now, so added a `Last 5 month`(This syntax is wrong )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (4c096d2) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.22%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.37% +3.22%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19606 -15117
+ Misses 10159 4786 -5373
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.37% <90.57%> (-0.44%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.27% <87.50%> (-0.31%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [555 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...2fefdf3](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (4c096d2) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.26%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.41% +3.26%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19615 -15108
+ Misses 10159 4777 -5382
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.41% <90.57%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.53% <87.50%> (-0.05%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...2fefdf3](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.21%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.36% +3.21%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19603 -15120
+ Misses 10159 4789 -5370
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.36% <90.57%> (-0.45%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.53% <87.50%> (-0.05%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [555 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (4c096d2) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.15%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.30% +3.15%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19589 -15134
+ Misses 10159 4803 -5356
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.30% <90.57%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.62% <87.50%> (-0.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [558 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...2fefdf3](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #13330:
URL: https://github.com/apache/superset/pull/13330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.28%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.43% +3.28%
==========================================
Files 866 300 -566
Lines 45005 24420 -20585
Branches 5357 0 -5357
==========================================
- Hits 34723 19642 -15081
+ Misses 10159 4778 -5381
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.43% <90.57%> (-0.38%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.54% <87.50%> (-0.04%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <93.33%> (-2.13%)` | :arrow_down: |
| ... and [545 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13330:
URL: https://github.com/apache/superset/pull/13330#discussion_r582621521
##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Last 5 month")
+ expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+ self.assertEqual(result, expected)
+
Review comment:
Could we make this UT test for the correct singular case "Last 1 month"? Having the "Last 5 month" test is probably a good additional test, but less important IMO.
##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Last 5 month")
+ expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+ self.assertEqual(result, expected)
+
result = get_since_until("Next 5 months")
expected = datetime(2016, 11, 7), datetime(2017, 4, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Next 5 month")
+ expected = datetime(2016, 11, 7), datetime(2017, 4, 7)
+ self.assertEqual(result, expected)
+
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (366a977) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `2.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 79.95% +2.80%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19503 -15220
+ Misses 10159 4889 -5270
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `79.95% <ø> (-0.86%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.69% <0.00%> (-24.88%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `79.95% <0.00%> (-6.12%)` | :arrow_down: |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `83.33% <0.00%> (-5.56%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <0.00%> (-5.56%)` | :arrow_down: |
| ... and [595 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (366a977) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **decrease** coverage by `5.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
- Coverage 77.15% 71.27% -5.88%
==========================================
Files 866 783 -83
Lines 45005 40535 -4470
Branches 5357 4133 -1224
==========================================
- Hits 34723 28892 -5831
- Misses 10159 11643 +1484
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.16% <ø> (-0.36%)` | :arrow_down: |
| javascript | `?` | |
| python | `79.95% <ø> (-0.86%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...odal/FiltersConfigForm/FilterScope/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL1Njb3BpbmdUcmVlLnRzeA==) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [superset-frontend/src/components/IconTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvblRvb2x0aXAudHN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| ... and [475 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13330:
URL: https://github.com/apache/superset/pull/13330#discussion_r582624277
##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Last 5 month")
+ expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+ self.assertEqual(result, expected)
+
Review comment:
thanks for reminding me. Because there is `Last 5 months` UT case now, so added a `Last 5 month`(This syntax is wrong ). singular and plural time units are now supported. Although sometimes the syntax is incorrect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.57%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.73% +3.57%
==========================================
Files 866 300 -566
Lines 45005 24420 -20585
Branches 5357 0 -5357
==========================================
- Hits 34723 19715 -15008
+ Misses 10159 4705 -5454
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.73% <90.57%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.54% <87.50%> (-0.04%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <93.33%> (-2.13%)` | :arrow_down: |
| ... and [542 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.68%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.84% +3.68%
==========================================
Files 866 300 -566
Lines 45005 24420 -20585
Branches 5357 0 -5357
==========================================
- Hits 34723 19742 -14981
+ Misses 10159 4678 -5481
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.84% <90.57%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.54% <87.50%> (-0.04%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.87% <93.33%> (-2.13%)` | :arrow_down: |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13330:
URL: https://github.com/apache/superset/pull/13330#discussion_r582628177
##########
File path: tests/utils/date_parser_tests.py
##########
@@ -88,10 +88,18 @@ def test_get_since_until(self):
expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Last 5 month")
+ expected = datetime(2016, 6, 7), datetime(2016, 11, 7)
+ self.assertEqual(result, expected)
+
result = get_since_until("Next 5 months")
expected = datetime(2016, 11, 7), datetime(2017, 4, 7)
self.assertEqual(result, expected)
+ result = get_since_until("Next 5 month")
+ expected = datetime(2016, 11, 7), datetime(2017, 4, 7)
+ self.assertEqual(result, expected)
+
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.26%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.41% +3.26%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19615 -15108
+ Misses 10159 4777 -5382
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.41% <90.57%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.53% <87.50%> (-0.05%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [552 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13330: fix: date picker support date unit with singular and plural
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13330:
URL: https://github.com/apache/superset/pull/13330#issuecomment-785708102
# [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=h1) Report
> Merging [#13330](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=desc) (862f64e) into [master](https://codecov.io/gh/apache/superset/commit/99a0c8a8a129502d6253e000c14db31ab8b0bb19?el=desc) (99a0c8a) will **increase** coverage by `3.15%`.
> The diff coverage is `90.57%`.
[](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13330 +/- ##
==========================================
+ Coverage 77.15% 80.30% +3.15%
==========================================
Files 866 300 -566
Lines 45005 24392 -20613
Branches 5357 0 -5357
==========================================
- Hits 34723 19589 -15134
+ Misses 10159 4803 -5356
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `80.30% <90.57%> (-0.51%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | `0.00% <ø> (ø)` | |
| [superset/utils/cache.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `76.34% <ø> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <ø> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.06% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `83.72% <71.42%> (-5.47%)` | :arrow_down: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `82.06% <75.00%> (-2.73%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.27% <81.25%> (-1.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.62% <87.50%> (-0.96%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.45% <92.85%> (+0.18%)` | :arrow_up: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <93.33%> (-2.18%)` | :arrow_down: |
| ... and [558 more](https://codecov.io/gh/apache/superset/pull/13330/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=footer). Last update [99a0c8a...366a977](https://codecov.io/gh/apache/superset/pull/13330?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org