You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/13 02:50:48 UTC

[GitHub] [pulsar] dragonls commented on a diff in pull request #17573: [fix][broker] Fix unexpected subscription deletion

dragonls commented on code in PR #17573:
URL: https://github.com/apache/pulsar/pull/17573#discussion_r969093945


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentSubscription.java:
##########
@@ -210,7 +210,7 @@ public void consumerFlow(Consumer consumer, int additionalNumberOfMessages) {
 
     @Override
     public void acknowledgeMessage(List<Position> position, AckType ackType, Map<String, Long> properties) {
-        // No-op
+        updateLastActive();

Review Comment:
   I will add a test to cover this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org