You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/19 09:04:04 UTC

[GitHub] [iotdb] wangchao316 commented on a diff in pull request #7057: [IOTDB-4125] Clear NodeCache and RegionGroupCache in time

wangchao316 commented on code in PR #7057:
URL: https://github.com/apache/iotdb/pull/7057#discussion_r949978047


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/RemoveConfigNodeProcedure.java:
##########
@@ -72,6 +68,7 @@ protected Flow executeFromState(ConfigNodeProcedureEnv env, RemoveConfigNodeStat
           LOG.info("Remove Consensus Group {}", tConfigNodeLocation);
           break;
         case STOP_CONFIG_NODE:
+          env.broadCastTheLatestConfigNodeGroup();

Review Comment:
   why ?  We should broadcast and quarantine before we delete it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org