You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/03/09 22:17:57 UTC
[PR] try protobuf-java 4.30.0 [pekko]
pjfanning opened a new pull request, #1795:
URL: https://github.com/apache/pekko/pull/1795
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2717874334
Pekko gRPC uses the io.grpc libs and has a direct dependency on the google protobuf jars. Pekko core depends on our shaded jar. So we can update independently. Pekko gRPC has a PR but it is blocked waiting on a new scalapb release. A new alpha release of scalapb 1.0.0 is due soon. https://github.com/apache/pekko-grpc/pull/371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #1795:
URL: https://github.com/apache/pekko/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try protobuf-java 4.30.0 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2709104987
GeneratedMessageV3 is deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try protobuf-java 4.29.3 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2717857440
> * Seems to work - tests pass
Very cool!
> * Big binary compatibility diffs for the generated classes
>
> Do we expect this to cause issues for users? I don't think they'll be coding against the generated classes. This would be target at the 1.2.0 release or if it's too big for there, we might need to consider delaying to 2.0.0.
>
> @raboof @kerr @Roiocam what do you think?
Indeed I typically don't expect those aspects of the generated classes to be user-facing. Looking at https://pekko.apache.org/docs/pekko/current/common/binary-compatibility-rules.html , while we haven't marked the generated code as 'internal API' as such, we do reserve the right to do major updates of dependencies, and this generated code is somewhat at the edge between being internal and being 'actually' part of the dependency.
Perhaps we should do the following: merge this PR, and then see if we can update Pekko gRPC to the Pekko snapshot without further changes (other than perhaps declared dependencies). Since Pekko gRPC also heavily relies on protobuf, if that builds without trouble, that's a strong indicator that the change is reasonably safe and we can release it with 1.2.0. If Pekko gRPC needs serious changes to work with that snapshot, then we should perhaps take this as the opportunity to make the next version Pekko 2.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2711371822
* Seems to work - tests pass
* Big binary compatibility diffs for the generated classes
Do we expect this to cause issues for users? I don't think they'll be coding against the generated classes.
This would be target at the 1.2.0 release or if it's too big for there, we might need to consider delaying to 2.0.0.
@raboof @kerr @Roiocam what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2814037673
Thanks @raboof - I agree that changing the name of the jar and the shaded package is not worth the hassle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2722230216
@raboof I added mima filter files to get the build to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2723189955
I checked https://github.com/grpc/grpc-java/blob/master/examples/pom.xml, I think we should keep using protobuf 3.x in 1.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2794752578
> > I checked https://github.com/grpc/grpc-java/blob/master/examples/pom.xml, I think we should keep using protobuf 3.x in 1.2.0
>
> This is covered in [#1795 (comment)](https://github.com/apache/pekko/pull/1795#issuecomment-2717874334)
>
> @raboof has suggested that maybe we could merge this and see what happens in the pekko-grpc build. I expect that it will have no effect but if it does, I will be happy to revert this.
@raboof do you think this is ok to merge? If it causes any downstream issues, I will revert it. I think this is reasonably unlikely to happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] try protobuf-java 4.29.3 [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2717879531
> Pekko gRPC uses the io.grpc libs and has a direct dependency on the google protobuf jars. Pekko core depends on our shaded jar. So we can update independently.
I agree that's the theory, but I'd like to see the practice ;)
> Pekko gRPC has a PR but it is blocked waiting on a new scalapb release. A new alpha release of scalapb 1.0.0 is due soon. [apache/pekko-grpc#371](https://github.com/apache/pekko-grpc/pull/371)
Jup, much looking forward to that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] protobuf-java 4.29.3 [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1795:
URL: https://github.com/apache/pekko/pull/1795#issuecomment-2724183201
> I checked https://github.com/grpc/grpc-java/blob/master/examples/pom.xml, I think we should keep using protobuf 3.x in 1.2.0
This is covered in https://github.com/apache/pekko/pull/1795#issuecomment-2717874334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org