You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/16 00:26:21 UTC
[GitHub] [incubator-mxnet] roywei commented on a change in pull request
#17322: Add event handlers in validation handler
roywei commented on a change in pull request #17322: Add event handlers in validation handler
URL: https://github.com/apache/incubator-mxnet/pull/17322#discussion_r367176134
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -181,14 +181,17 @@ class ValidationHandler(TrainBegin, BatchEnd, EpochEnd):
Priority level of the ValidationHandler. Priority level is sorted in
ascending order. The lower the number is, the higher priority level the
handler is.
+ event_handlers : EventHandler or list of EventHandlers
Review comment:
Could you add more detailed doc? Something like " EventHandler or list of EventHandlers to be used by the `eval_fn`". Otherwise, it will be confusing for users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services