You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@skywalking.apache.org by ha...@apache.org on 2018/05/26 09:16:21 UTC

[incubator-skywalking-ui] 04/04: Fix #169 Filtering invalid edge data

This is an automated email from the ASF dual-hosted git repository.

hanahmily pushed a commit to branch 5.0.0/beta2
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-ui.git

commit a82f950b35c9fa121b53e05baf7c9d462205e593
Author: gaohongtao <ha...@gmail.com>
AuthorDate: Sat May 26 17:15:59 2018 +0800

    Fix #169 Filtering invalid edge data
---
 mock/service.js               | 2 ++
 src/routes/Service/Service.js | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/mock/service.js b/mock/service.js
index dcb37f4..055d739 100644
--- a/mock/service.js
+++ b/mock/service.js
@@ -104,6 +104,7 @@ export default {
                 },
               ],
             });
+            downNodes.nodes.push({ id: -111 });
             const nodes = upNodes.nodes.concat(centerNodes.nodes, downNodes.nodes);
             const calls = upNodes.nodes.map(node => (mockjs.mock({
               source: node.id,
@@ -120,6 +121,7 @@ export default {
               'cpm|0-2000': 1,
               'avgResponseTime|500-5000': 1,
             }))));
+            calls.push({ source: '-175', target: 1, isAlert: false, callType: 'GRPC', cpm: 0, avgResponseTime: 52 });
             return {
               nodes,
               calls,
diff --git a/src/routes/Service/Service.js b/src/routes/Service/Service.js
index 82ac1c5..de04082 100644
--- a/src/routes/Service/Service.js
+++ b/src/routes/Service/Service.js
@@ -212,8 +212,10 @@ export default class Service extends PureComponent {
     });
     const nData = {
       nodes: data.nodes,
-      edges: data.calls.map(_ =>
-        ({ ..._, value: (this.edgeWith(_) < 1 ? 1000 : this.edgeWith(_)), source: nodesMap.get(`${_.source}`), target: nodesMap.get(`${_.target}`) })),
+      edges: data.calls
+        .filter(_ => nodesMap.has(`${_.source}`) && nodesMap.has(`${_.target}`))
+        .map(_ =>
+          ({ ..._, value: (this.edgeWith(_) < 1 ? 1000 : this.edgeWith(_)), source: nodesMap.get(`${_.source}`), target: nodesMap.get(`${_.target}`) })),
     };
     return (
       <Row gutter={8}>

-- 
To stop receiving notification emails like this one, please contact
hanahmily@apache.org.