You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "desiderantes (via GitHub)" <gi...@apache.org> on 2026/06/16 19:18:26 UTC

[PR] Remove @Experimental mark for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

desiderantes opened a new pull request, #673:
URL: https://github.com/apache/httpcomponents-core/pull/673

   ###  Removing Experimental Markings
   
   Since the QUERY method draft has been promoted to a proper [RFC]( https://www.rfc-editor.org/rfc/rfc10008.html), this change removes the @Experimental tag from   QUERY method.
   
   ### RFC 10008 Conformance
   
     According to Section 2 of RFC 10008 https://www.rfc-editor.org/rfc/rfc10008.html:
   
     │ Servers MUST fail the request if the Content-Type request field is missing or is inconsistent with the request content.
   
     I've added code to enforce this constraint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [PR] Remove @Experimental for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

Posted by "desiderantes (via GitHub)" <gi...@apache.org>.
desiderantes commented on PR #673:
URL: https://github.com/apache/httpcomponents-core/pull/673#issuecomment-4752343617

   > > Hi, in this case, the prior change implemented basic QUERY method support, while the RFC was in draft status. After it graduated from that status, there were now missing parts for conformance, which I add with this PR.
   > 
   > @desiderantes What I am trying to say we need to be sure the protocol code fully conforms to RFC 10008 in terms of hard requirements before we can remove `experimental` annotation. If your change-set already covers all those requirements then all is well.
   
   Ah, got you, no problem. Yes, the required changes in this project were minimal from my point of view. There is another PR for the client itself that handles the changes required there, and I referenced this PR from that one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [PR] Remove @Experimental for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #673:
URL: https://github.com/apache/httpcomponents-core/pull/673#issuecomment-4749803538

   > Hi, in this case, the prior change implemented basic QUERY method support, while the RFC was in draft status. After it graduated from that status, there were now missing parts for conformance, which I add with this PR.
   
   @desiderantes What I am trying to say we need to be sure the protocol code fully conforms to RFC 10008 in terms of hard requirements before we can remove `experimental` annotation. If your change-set already covers all those requirements then all is well.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [PR] Remove @Experimental for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

Posted by "desiderantes (via GitHub)" <gi...@apache.org>.
desiderantes commented on PR #673:
URL: https://github.com/apache/httpcomponents-core/pull/673#issuecomment-4746228818

   > @desiderantes I will do my best to get around to reviewing this change-set and including it in the upcoming 5.5-beta2 release. Please note though we usually do not upgrade to RFCs piecemeal. We need to be sure that at the very least all hard requirements are met
   
   Hi, in this case, the prior change implemented basic QUERY method support, while the RFC was in draft status. After it graduated from that status, there were now missing parts for conformance, which I add with this PR.
   
   > Please also add RFC 10008 to the list of RFCs the library conforms to in README.md
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [PR] Remove @Experimental for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #673:
URL: https://github.com/apache/httpcomponents-core/pull/673#issuecomment-4745842020

   @desiderantes I will do my best to get around to reviewing this change-set and including it in the upcoming 5.5-beta2 release. Please note though we usually do not upgrade to RFCs piecemeal. We need to be sure that at the very least all hard requirements are met
   
   Please also add RFC 10008 to the list of RFCs the library conforms to in README.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: [PR] Remove @Experimental for QUERY method and implement conformance to RFC 10008 [httpcomponents-core]

Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #673:
URL: https://github.com/apache/httpcomponents-core/pull/673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org