You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/28 02:40:56 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4869: Adding
pinot-spi module and moving record reader interface
codecov-io commented on issue #4869: Adding pinot-spi module and moving record reader interface
URL: https://github.com/apache/incubator-pinot/pull/4869#issuecomment-559318125
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=h1) Report
> Merging [#4869](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1ba62059e8d6b8386e94d8d71a44b52db6fbf329?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `27.58%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4869 +/- ##
============================================
+ Coverage 57.74% 57.75% +0.01%
Complexity 4 4
============================================
Files 1200 1201 +1
Lines 64658 64659 +1
Branches 9390 9389 -1
============================================
+ Hits 37334 37342 +8
+ Misses 24553 24543 -10
- Partials 2771 2774 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../data/aggregator/PercentileEstValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvUGVyY2VudGlsZUVzdFZhbHVlQWdncmVnYXRvci5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/core/data/readers/GenericRowRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvR2VuZXJpY1Jvd1JlY29yZFJlYWRlci5qYXZh) | `93.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...org/apache/pinot/core/minion/SegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9taW5pb24vU2VnbWVudENvbnZlcnRlci5qYXZh) | `71.95% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/realtime/impl/kafka/KafkaAvroMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1jb25uZWN0b3Ita2Fma2EtYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2thZmthL0thZmthQXZyb01lc3NhZ2VEZWNvZGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...re/startree/v2/store/StarTreeMetricDataSource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZU1ldHJpY0RhdGFTb3VyY2UuamF2YQ==) | `54.16% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/core/startree/v2/store/StarTreeLoaderUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9zdG9yZS9TdGFyVHJlZUxvYWRlclV0aWxzLmphdmE=) | `93.65% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...t/common/response/broker/BrokerResponseNative.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0Jyb2tlclJlc3BvbnNlTmF0aXZlLmphdmE=) | `91.57% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...not/core/plan/maker/BrokerRequestPreProcessor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wbGFuL21ha2VyL0Jyb2tlclJlcXVlc3RQcmVQcm9jZXNzb3IuamF2YQ==) | `75% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `83.83% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `94.05% <ø> (-0.55%)` | `0 <0> (ø)` | |
| ... and [258 more](https://codecov.io/gh/apache/incubator-pinot/pull/4869/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=footer). Last update [1ba6205...4b9c050](https://codecov.io/gh/apache/incubator-pinot/pull/4869?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org