[GitHub] [flink-kubernetes-operator] bgeng777 commented on a diff in pull request #173: [FLINK-27310] Fix FlinkOperatorITCase

[GitBox <gi...@apache.org>]

bgeng777 commented on code in PR #173:
URL: https://github.com/apache/flink-kubernetes-operator/pull/173#discussion_r853701580


##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/FlinkOperatorITCase.java:
##########
@@ -114,6 +114,7 @@ private static FlinkDeployment buildSessionCluster() {
         resource.setCpu(1);
         JobManagerSpec jm = new JobManagerSpec();
         jm.setResource(resource);
+        jm.setReplicas(1);

Review Comment:
   Without this setting, `replicas` in `JobManagerSpec` will be zero be default. That's why the IT test failed.
   So do you mean we should change the default value of `replicas` in the class? It seems to be a better solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org