[jira] [Commented] (SOLR-14316) Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method

["David Smiley (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066133#comment-17066133 ] 

David Smiley commented on SOLR-14316:
-------------------------------------

FWIW I think this sort of change belongs in "Other" instead of improvements because it's not something a user would ever notice/see.

> Remove unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-14316
>                 URL: https://issues.apache.org/jira/browse/SOLR-14316
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: 7.7.2, 8.4.1
>            Reporter: Aroop
>            Priority: Minor
>              Labels: patch
>             Fix For: master (9.0), 8.6
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> There is an unchecked type conversion warning in JavaBinCodec's readMapEntry's equals() method. 
> This change removes that warning by handling a checked conversion and also adds to tests to an earlier untested api.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org