[GitHub] [skywalking-java] ArjenDavid-sjtu commented on a change in pull request #91: Feature/redis plugins config

[GitBox <gi...@apache.org>]

ArjenDavid-sjtu commented on a change in pull request #91:
URL: https://github.com/apache/skywalking-java/pull/91#discussion_r783850335



##########
File path: test/plugin/scenarios/jedis-scenario/bin/startup.sh
##########
@@ -18,5 +18,5 @@
 
 home="$(cd "$(dirname $0)"; pwd)"
 
-java -jar ${agent_opts} -Dredis.host=${REDIS_HOST} -Dredis.port=${REDIS_PORT} \
+java -jar ${agent_opts} -Dredis.host=${REDIS_HOST} -Dredis.port=${REDIS_PORT} -Dskywalking.plugin.jedis.trace_redis_parameters=true\

Review comment:
       Both plugins support collecting redis parameters previously, what I do was to add a switch to disable the collection. So the tag don't need to change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org