You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/20 17:47:35 UTC
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8565: Add PercentileSmartTDigestAggregationFunction
Jackie-Jiang commented on code in PR #8565:
URL: https://github.com/apache/pinot/pull/8565#discussion_r854401117
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java:
##########
@@ -52,6 +52,9 @@ public static AggregationFunction getAggregationFunction(FunctionContext functio
ExpressionContext firstArgument = arguments.get(0);
if (upperCaseFunctionName.startsWith("PERCENTILE")) {
String remainingFunctionName = upperCaseFunctionName.substring(10);
+ if (remainingFunctionName.equals("SMARTTDIGEST")) {
Review Comment:
It's already canonicalized, so no need to ignore case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org