You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "xiazcy (via GitHub)" <gi...@apache.org> on 2023/04/12 22:48:13 UTC
[GitHub] [tinkerpop] xiazcy opened a new pull request, #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
xiazcy opened a new pull request, #2020:
URL: https://github.com/apache/tinkerpop/pull/2020
Same changes as #2019, but for 3.6-dev instead, as there was an added null check in hasId() for 3.6, which led to changes to the Gherkin test suites.
It appears that the previous implementation of hasId() omitted adding `null` to the Bytecode step if `otherIds` were `null`, which unintentionally removed tailing nulls from traversals and in the test files.
I'll squash all commits into one when this is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #2020:
URL: https://github.com/apache/tinkerpop/pull/2020#discussion_r1164737333
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2528,7 +2524,7 @@ public default GraphTraversal<S, E> property(final VertexProperty.Cardinality ca
* the {@link Graph} will be used.
* <p/>
* If a {@link Map} is supplied then each of the key/value pairs in the map will
- * be added as property. This method is the long-hand version of looping through the
+ * be added as property. This method is the long-hand version of looping through the
Review Comment:
```suggestion
* be added as property. This method is the long-hand version of looping through the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #2020:
URL: https://github.com/apache/tinkerpop/pull/2020#discussion_r1164736990
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2446,7 +2442,7 @@ public default GraphTraversal<S, TraversalMetrics> profile() {
* and if the {@link Element} is a {@link VertexProperty}. This method is the long-hand version of
* {@link #property(Object, Object, Object...)} with the difference that the {@link VertexProperty.Cardinality}
* can be supplied.
- * <p/>*
+ * <p/>*
Review Comment:
```suggestion
* <p/>*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2020:
URL: https://github.com/apache/tinkerpop/pull/2020#issuecomment-1506078740
## [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/2020?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2020](https://codecov.io/gh/apache/tinkerpop/pull/2020?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9dd83a1) into [3.6-dev](https://codecov.io/gh/apache/tinkerpop/commit/3249e5856fee577cae9a2f69260cbc6c6c1ffd66?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3249e58) will **decrease** coverage by `4.91%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9dd83a1 differs from pull request most recent head bd8253e. Consider uploading reports for the commit bd8253e to get more accurate results
```diff
@@ Coverage Diff @@
## 3.6-dev #2020 +/- ##
=============================================
- Coverage 69.41% 64.51% -4.91%
=============================================
Files 878 25 -853
Lines 42083 3793 -38290
Branches 5640 0 -5640
=============================================
- Hits 29212 2447 -26765
+ Misses 10877 1179 -9698
+ Partials 1994 167 -1827
```
[see 853 files with indirect coverage changes](https://codecov.io/gh/apache/tinkerpop/pull/2020/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy merged pull request #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2020:
URL: https://github.com/apache/tinkerpop/pull/2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #2020: TINKERPOP-2863 Update hasId step mid-traversal processing - 3.6-dev
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on code in PR #2020:
URL: https://github.com/apache/tinkerpop/pull/2020#discussion_r1164737644
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2561,14 +2557,14 @@ public default GraphTraversal<S, E> property(final Object key, final Object valu
return this.property(null, key, value, keyValues);
}
}
-
+
/**
* When a {@link Map} is supplied then each of the key/value pairs in the map will
- * be added as property. This method is the long-hand version of looping through the
+ * be added as property. This method is the long-hand version of looping through the
Review Comment:
```suggestion
* be added as property. This method is the long-hand version of looping through the
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org