[GitHub] [spark] rednaxelafx commented on a change in pull request #29771: [SPARK-32635][SQL] Fix foldable propagation

[GitBox <gi...@apache.org>]

rednaxelafx commented on a change in pull request #29771:
URL: https://github.com/apache/spark/pull/29771#discussion_r490416252



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -624,67 +624,89 @@ object NullPropagation extends Rule[LogicalPlan] {
  */
 object FoldablePropagation extends Rule[LogicalPlan] {
   def apply(plan: LogicalPlan): LogicalPlan = {
-    var foldableMap = AttributeMap(plan.flatMap {
-      case Project(projectList, _) => projectList.collect {

Review comment:
       I had the same question when I first looked at the PR, but since this PR might need to be hotfixed to released branches, it's a good idea to keep it simple and don't add any new features. So I'm +1 for handling Aggregate in a separate PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org