You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by rf...@apache.org on 2020/05/15 07:06:12 UTC

[maven-release] branch master updated: Remove unused private fields Remove constructors with unused parameters

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-release.git


The following commit(s) were added to refs/heads/master by this push:
     new 57d6b59  Remove unused private fields Remove constructors with unused parameters
57d6b59 is described below

commit 57d6b591cabfc1b1b417db28f723fbb9a94dc989
Author: Piotrek Żygieło <pz...@users.noreply.github.com>
AuthorDate: Fri May 15 09:05:50 2020 +0200

    Remove unused private fields
    Remove constructors with unused parameters
    
    Signed-off-by: rfscholte <rf...@apache.org>
---
 .../maven/shared/release/exec/ForkedMavenExecutor.java   |  5 ++---
 .../maven/shared/release/exec/InvokerMavenExecutor.java  |  2 +-
 .../shared/release/exec/MavenExecutorException.java      | 16 +---------------
 3 files changed, 4 insertions(+), 19 deletions(-)

diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
index e4a5539..af0051f 100644
--- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
+++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java
@@ -141,13 +141,12 @@ public class ForkedMavenExecutor
 
                 if ( result != 0 )
                 {
-                    throw new MavenExecutorException( "Maven execution failed, exit code: \'" + result + "\'", result,
-                                                      stdOut.toString(), stdErr.toString() );
+                    throw new MavenExecutorException( "Maven execution failed, exit code: \'" + result + "\'", result );
                 }
             }
             catch ( CommandLineException e )
             {
-                throw new MavenExecutorException( "Can't run goal " + goals, stdOut.toString(), stdErr.toString(), e );
+                throw new MavenExecutorException( "Can't run goal " + goals, e );
             }
             finally
             {
diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
index df61c39..eb9e044 100644
--- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
+++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java
@@ -392,7 +392,7 @@ public class InvokerMavenExecutor
                 {
                     throw new MavenExecutorException(
                         "Maven execution failed, exit code: \'" + invocationResult.getExitCode() + "\'",
-                        invocationResult.getExitCode(), "", "" );
+                        invocationResult.getExitCode() );
                 }
             }
             catch ( MavenInvocationException e )
diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/MavenExecutorException.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/MavenExecutorException.java
index 3bd996c..74300c7 100644
--- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/MavenExecutorException.java
+++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/MavenExecutorException.java
@@ -27,27 +27,13 @@ package org.apache.maven.shared.release.exec;
 public class MavenExecutorException
     extends Exception
 {
-    private String stdErr;
-
-    private String stdOut;
-
     private int exitCode;
 
-    public MavenExecutorException( String message, int exitCode, String stdOut, String stdErr )
+    public MavenExecutorException( String message, int exitCode )
     {
         super( message );
 
         this.exitCode = exitCode;
-        this.stdOut = stdOut;
-        this.stdErr = stdErr;
-    }
-
-    public MavenExecutorException( String message, String stdOut, String stdErr, Exception e )
-    {
-        super( message, e );
-
-        this.stdOut = stdOut;
-        this.stdErr = stdErr;
     }
 
     public MavenExecutorException( String message, Throwable cause )