[GitHub] [geode] Bill commented on pull request #3049: *DO NOT MERGE* Explore building configuration REST service using Kotlin

["Bill (GitHub)" <gi...@apache.org>]

It's surprising that this function is mutating an object referenced by one of its arguments. I was initially looking to see what this function _returns_ (and I was disappointed.)

I understand that `RegionAttributesType` (and `RegionConfig`) as currently constituted works via mutation. But maybe this would be a good time to consider a new immutable approach to building these structures. Haven't thought that through. On first thought it introduces parallel maintenance.

Another way to make this function functional would be to return a new `RegionConfig` (and promise not to mutate the one sent in).

[ Full content available at: https://github.com/apache/geode/pull/3049 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org