[GitHub] [pinot] KKcorps commented on a diff in pull request #9008: Add TLS1.3, Remove TLS1.0, Add User Agent Header, Add Timeouts for Pi…

[GitBox <gi...@apache.org>]

KKcorps commented on code in PR #9008:
URL: https://github.com/apache/pinot/pull/9008#discussion_r913395201


##########
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/controller/PinotControllerTransport.java:
##########
@@ -45,6 +46,12 @@ public class PinotControllerTransport {
 
   private static final Logger LOGGER = LoggerFactory.getLogger(PinotControllerTransport.class);
 
+  private static final long READ_TIMEOUT_MS = 60000L;
+
+  private static final int CONNECT_TIMEOUT_MS = 2000;
+
+  private static final int HANDSHAKE_TIMEOUT_MS = 2000;

Review Comment:
   Can we also add a way to configure these timeouts with jdbc properties. Users may want to change these values.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org