You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/11 10:00:35 UTC

[GitHub] [rocketmq] pirateskipper opened a new pull request #3247: Safely delete parameters and variables that have never been used

pirateskipper opened a new pull request #3247:
URL: https://github.com/apache/rocketmq/pull/3247


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   - Streamline code and increase readability
   
   ## Brief changelog
   
   - Safely delete parameters and variables that have never been used
   - Related change files：DefaultRequestProcessor && KVConfigManager
   
   ## Verifying this change
   
   - Verified
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3247: Safely delete parameters and variables that have never been used

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #3247:
URL: https://github.com/apache/rocketmq/pull/3247#issuecomment-896979957


   
   [![Coverage Status](https://coveralls.io/builds/42059840/badge)](https://coveralls.io/builds/42059840)
   
   Coverage decreased (-0.1%) to 53.992% when pulling **e52fc184773b63d343cfbbfc1342eb5dd1d75d72 on pirateskipper:r-issues** into **5203d52f1bab431ada236ba279c80e62778f8a15 on apache:release-4.9.0**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] pirateskipper closed pull request #3247: Safely delete parameters and variables that have never been used

Posted by GitBox <gi...@apache.org>.

pirateskipper closed pull request #3247:
URL: https://github.com/apache/rocketmq/pull/3247


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org