You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/01/20 21:33:04 UTC
[GitHub] [incubator-tvm] tqchen opened a new pull request #4752: [REFACTOR]
Establish printer in the source folder
tqchen opened a new pull request #4752: [REFACTOR] Establish printer in the source folder
URL: https://github.com/apache/incubator-tvm/pull/4752
As we move towards the unified IR, we will eventually want to build a unified
printers for both relay and TIR.
This PR isolate the printer component into a separate folder in src as a first step.
- Refactored the Doc DSL using Object, clean up APIs.
- Isolate out the meta data into a header.
- move printer into relay_text_printer, add comments about further TODos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen edited a comment on issue #4752: [REFACTOR]
Establish printer in the source folder
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #4752: [REFACTOR] Establish printer in the source folder
URL: https://github.com/apache/incubator-tvm/pull/4752#issuecomment-576509477
Thanks @MarisaKirisame @ZihengJiang We will keep ReprPrintr and TextPrinter separate but might redirect some of the ReprPrinter to TextPrinter when it makes sense. There are list of todos in the text printer to add more support for the low-level IR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4752: [REFACTOR]
Establish printer in the source folder
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4752: [REFACTOR] Establish printer in the source folder
URL: https://github.com/apache/incubator-tvm/pull/4752#issuecomment-576436815
cc @MarisaKirisame @jroesch @spectrometerHBH @Hzfengsy @ZihengJiang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4752: [REFACTOR]
Establish printer in the source folder
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4752: [REFACTOR] Establish printer in the source folder
URL: https://github.com/apache/incubator-tvm/pull/4752#issuecomment-576509477
Thanks @MarisaKirisame @ZihengJiang We will keep ReprPrintr and TextPrinter separate but might redirect some of the ReprPrinter to TextPrinter when it makes sense. There are list of todos in the text printer to add more support for low-level IR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen merged pull request #4752: [REFACTOR]
Establish printer in the source folder
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #4752: [REFACTOR] Establish printer in the source folder
URL: https://github.com/apache/incubator-tvm/pull/4752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services