You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "brancz (via GitHub)" <gi...@apache.org> on 2023/08/29 15:21:10 UTC

[GitHub] [arrow] brancz opened a new pull request, #37438: MINOR: [Go] Export IndexBuilder struct

brancz opened a new pull request, #37438:
URL: https://github.com/apache/arrow/pull/37438

   We allow accessing the IndexBuilder since GH-37416 merged. While the `Builder` interface functions can be accessed, the actual array builder cannot.
   
   ### Rationale for this change
   
   #37416 added the function to access the index builder, but since it returns the `Builder` interface, we can't actually access the underlying builder as the unexported `IndexBuilder` is unexported.
   
   Alternatives could be:
   
   * Return `indexBuilder.Builder` instead in the `IndexBuilder()` function
   * Return the unexported `indexBuilder` type, but this tends to be more awkward to use
   
   ### What changes are included in this PR?
   
   Exporting the type so it can be type asserted.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   Yes, but this API hasn't been released yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37438: MINOR: [Go] Export IndexBuilder struct

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37438:
URL: https://github.com/apache/arrow/pull/37438#issuecomment-1700292220

   After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 439d066effa7b774a47c8a9727a14741fc46de99.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/16367655008) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] zeroshade merged pull request #37438: MINOR: [Go] Export IndexBuilder struct

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #37438:
URL: https://github.com/apache/arrow/pull/37438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] brancz commented on pull request #37438: MINOR: [Go] Export IndexBuilder struct

Posted by "brancz (via GitHub)" <gi...@apache.org>.
brancz commented on PR #37438:
URL: https://github.com/apache/arrow/pull/37438#issuecomment-1697657567

   cc @zeroshade 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org