[GitHub] [arrow] alamb commented on a change in pull request #9605: ARROW-11802: [Rust][DataFusion] Remove use of crossbeam channels to avoid potential deadlocks

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #9605:
URL: https://github.com/apache/arrow/pull/9605#discussion_r584685022



##########
File path: rust/datafusion/src/physical_plan/repartition.rs
##########
@@ -199,14 +211,12 @@ impl ExecutionPlan for RepartitionExec {
                     }
 
                     // notify each output partition that this input partition has no more data
-                    for channel in channels.iter_mut().take(num_output_partitions) {
-                        let tx = &mut channel.0;
+                    for (_, tx) in txs {
                         tx.send(None)
                             .map_err(|e| DataFusionError::Execution(e.to_string()))?;
                     }
                     Ok(())
                 });
-                tokio::task::yield_now().await;

Review comment:
       this is the workaround added in https://github.com/apache/arrow/pull/9580 and it is now removed in favor of what we think is the fix of the root cause




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org