You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/10 16:23:22 UTC
[GitHub] [airflow] ephraimbuddy opened a new pull request #14700: Fix false warning about class that was not used in a dag file
ephraimbuddy opened a new pull request #14700:
URL: https://github.com/apache/airflow/pull/14700
Running upgrade_check with this import in a dag:
from airflow.operators.slack_operator import SlackAPIPostOperator
Causes these warnings:
[1] Using `airflow.operators.slack_operator.SlackAPIPostOperator` should be replaced by `airflow.providers.slack.operators.slack.SlackAPIPostOperator`.
[2] Using `airflow.operators.slack_operator.SlackAPIOperator` should be replaced by `airflow.providers.slack.operators.slack.SlackAPIOperator`
Only 1 above is correct.
This PR fixes it by checking that both the old import part and class name exists in the dag before issuing warning
Related slack conversation: https://apache-airflow.slack.com/archives/CCPRP7943/p1615388292013900
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14700: Fix false warning about class that was not used in a dag file
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14700:
URL: https://github.com/apache/airflow/pull/14700#issuecomment-795804074
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14700: Fix false warning about class that was not used in a dag file
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14700:
URL: https://github.com/apache/airflow/pull/14700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org