You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2025/11/30 15:18:04 UTC
[PR] SOLR-11373: Enable infoStream logging [solr]
epugh opened a new pull request, #3910:
URL: https://github.com/apache/solr/pull/3910
https://issues.apache.org/jira/browse/SOLR-11373
# Description
Writing to this logger is now controlled by the infoStream property in solrconfig.xml.
# Solution
Stumbled across this when investigating https://issues.apache.org/jira/browse/SOLR-10488. I believe that having a noop InfoStream, which is what you get when it's set to False, means that having the async logger at info won't matter.
I don't know why we decided to not have it write to it's own file...
# Tests
Should we add a .bats test?
I tested manually with a configset with infoStream and one without being enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-11373: Enable infoStream logging [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3910:
URL: https://github.com/apache/solr/pull/3910#issuecomment-3593679504
> Please not yet another bats test; they are very heavy, and only a couple people maintain them.
>
> Its weird that solrconfig.xml has an infoStream setting. I suppose to prevent accidental enabling of very low level logging. But IMO that should be addressed with suitable log levels. This should be debug or trace level, and furthermore use a Lucene namespace not Solr, which is merely adding a factory in a sense. Then we wouldn't feel the need for a separate infoStream setting. There is a lot I might want to do to improve LoggingInfoStream, albeit out-of-scope here.
>
> Another problem is that it's misleading looking at this log configuration. One would _easily_ guess that they will see this low level stuff. That's a trap. Eric, can you please add a comment that the logging is actually/mostly controlled by solrconfig.xml infoStream ?
I think one reason that infostream isn't controlled by log4j2.xml is because you can choose PER core (collection) if it should be logging, and that's why it's in solrconfig.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-11373: Enable infoStream logging [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #3910:
URL: https://github.com/apache/solr/pull/3910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org