You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ta...@apache.org on 2022/12/02 22:08:30 UTC
[tika] branch TIKA-3943 created (now bf663b0fa)
This is an automated email from the ASF dual-hosted git repository.
tallison pushed a change to branch TIKA-3943
in repository https://gitbox.apache.org/repos/asf/tika.git
at bf663b0fa TIKA-3943 -- include inherited getters and setters in serialization of params
This branch includes the following new commits:
new bf663b0fa TIKA-3943 -- include inherited getters and setters in serialization of params
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[tika] 01/01: TIKA-3943 -- include inherited getters and setters in serialization of params
Posted by ta...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
tallison pushed a commit to branch TIKA-3943
in repository https://gitbox.apache.org/repos/asf/tika.git
commit bf663b0faa74a52aaff26283f5f30bec45dfb931
Author: tballison <ta...@apache.org>
AuthorDate: Fri Dec 2 17:08:21 2022 -0500
TIKA-3943 -- include inherited getters and setters in serialization of params
---
.../java/org/apache/tika/config/TikaConfigSerializer.java | 2 +-
.../java/org/apache/tika/config/TikaConfigSerializerTest.java | 11 +++++++++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/tika-core/src/main/java/org/apache/tika/config/TikaConfigSerializer.java b/tika-core/src/main/java/org/apache/tika/config/TikaConfigSerializer.java
index 598651a2c..a2313f408 100644
--- a/tika-core/src/main/java/org/apache/tika/config/TikaConfigSerializer.java
+++ b/tika-core/src/main/java/org/apache/tika/config/TikaConfigSerializer.java
@@ -348,7 +348,7 @@ public class TikaConfigSerializer {
MethodTuples primitiveSetters = new MethodTuples();
MethodTuples nonPrimitiveGetters = new MethodTuples();
MethodTuples primitiveGetters = new MethodTuples();
- for (Method method : object.getClass().getDeclaredMethods()) {
+ for (Method method : object.getClass().getMethods()) {
Class[] parameterTypes = method.getParameterTypes();
if (setterMatcher.reset(method.getName()).find()) {
diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/config/TikaConfigSerializerTest.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/config/TikaConfigSerializerTest.java
index 0c354e474..d7313db6f 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/config/TikaConfigSerializerTest.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/config/TikaConfigSerializerTest.java
@@ -17,6 +17,7 @@
package org.apache.tika.config;
import static org.apache.tika.TikaTest.assertContains;
+import static org.apache.tika.TikaTest.assertContainsCount;
import static org.apache.tika.TikaTest.assertNotContained;
import java.io.ByteArrayInputStream;
@@ -81,6 +82,16 @@ public class TikaConfigSerializerTest {
}
}
+ @Test
+ public void testOfficeParserParams() throws Exception {
+ TikaConfig tikaConfig = TikaConfig.getDefaultConfig();
+ StringWriter writer = new StringWriter();
+ TikaConfigSerializer.serialize(tikaConfig, TikaConfigSerializer.Mode.STATIC_FULL,
+ writer, StandardCharsets.UTF_8);
+ assertContainsCount("<param name=\"concatenatePhoneticRuns\" type=\"bool\">true</param>",
+ writer.toString(), 3);
+ }
+
private Path getPath(String config) {
try {
return Paths.get(TikaConfigSerializerTest.class.getResource("/configs/" + config)