You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zhaoyongjie (via GitHub)" <gi...@apache.org> on 2023/06/08 15:52:45 UTC
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #24323: chore: changing FLASK_ENV to FLASK_DEBUG
zhaoyongjie commented on code in PR #24323:
URL: https://github.com/apache/superset/pull/24323#discussion_r1223242745
##########
superset/config.py:
##########
@@ -1573,7 +1573,7 @@ class ExtraRelatedQueryFilters(TypedDict, total=False):
try:
# pylint: disable=import-error,wildcard-import,unused-wildcard-import
import superset_config
- from superset_config import * # type: ignore
Review Comment:
bycatch, I think it shouldn't add a type ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org