[GitHub] [arrow-datafusion] smiklos commented on a diff in pull request #7002: avoid copying listarray in unset exec

["smiklos (via GitHub)" <gi...@apache.org>]

smiklos commented on code in PR #7002:
URL: https://github.com/apache/arrow-datafusion/pull/7002#discussion_r1265528062


##########
datafusion/core/src/physical_plan/unnest.rs:
##########
@@ -236,21 +236,21 @@ fn build_batch(
     match list_array.data_type() {
         DataType::List(_) => {
             let list_array = list_array.as_any().downcast_ref::<ListArray>().unwrap();
-            unnest_batch(batch, schema, column, &list_array)
+            unnest_batch(batch, schema, column, &list_array, list_array.values())

Review Comment:
   `.values` seems to not have a common trait so it needs to be passed down here where we have the concrete types



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org