You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/17 01:06:20 UTC
[GitHub] [skywalking-client-js] Jtrust opened a new pull request #59: perf: Separate production and development environments when building
Jtrust opened a new pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59
Remove the plugin for the development environment when building for production
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #59: perf: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59#issuecomment-841916450
@arugal Let's tag and release 0.5.1 first, then we could move on 0.6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] Fine0830 edited a comment on pull request #59: perf: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
Fine0830 edited a comment on pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59#issuecomment-853037927
Uh...`start` and `server` are only needed for the development env. `build` is for production env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] Fine0830 commented on pull request #59: perf: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59#issuecomment-853037927
Uhh...`start` and `server` are only needed for the development env. `build` is for production env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] Fine0830 merged pull request #59: build: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] Fine0830 commented on a change in pull request #59: perf: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59#discussion_r646232062
##########
File path: package-lock.json
##########
@@ -1301,7 +1310,7 @@
},
"dedent": {
"version": "0.7.0",
- "resolved": "https://registry.npmjs.org/dedent/-/dedent-0.7.0.tgz",
+ "resolved": "https://registry.npm.taobao.org/dedent/download/dedent-0.7.0.tgz",
Review comment:
You shouldn't update the resolved url to `registry.npm.taobao.org`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on pull request #59: perf: Separate production and development environments when building
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #59:
URL: https://github.com/apache/skywalking-client-js/pull/59#issuecomment-841916450
@arugal Let's tag and release 0.5.1 first, then we could move on 0.6.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org